S3 Export halts on invalid symlinks

thaiphan / magento-s3

Use Amazon S3 as the file storage solution for your Magento store

MIT License

64 stars 22 forks source link

S3 Export halts on invalid symlinks #2

Closed garethmidwood closed 6 years ago

garethmidwood commented 7 years ago

When a media file is actually a symlink and the target file does not exist then the s3_export script halts with no explanation.

Perhaps it should skip the file and offer an error report at the end, or fail immediately with an error?

thaiphan commented 6 years ago

Hi @garethmidwood,

I have applied a partial fix to address exports to S3 failing on broken symlinks. The command line tool should now just ignore broken symlinks. However, the admin interface was too difficult to address since it requires overriding some more core functionality that I'm not comfortable doing at the point in time.

Regards,

Thai