search

thaiphan / magento2-s3

Use Amazon S3 as the file storage solution for your Magento 2 application
MIT License
142 stars 95 forks source link

app:config:dump exporting sensitive information #62

Closed chocolatethunder closed 5 years ago

chocolatethunder commented 6 years ago

When running 

php bin/magento app:config:dump

The S3 access keys are being exported to the config.php and not env.php

This is causing deployment pipeline issues because config.php is supposed to be part of version control and env.php is not. Don't want to accidentally publish my AWS data to Github.

Additionally, I have also tried adding this to app/etc/di.xml file

<type name="Magento\Config\Model\Config\TypePool">
   <arguments>
      <argument name="sensitive" xsi:type="array">
         <item name="thai_s3/general/access_key" xsi:type="string">1</item>
         <item name="thai_s3/general/secret_key" xsi:type="string">1</item>
      </argument>
   </arguments>
</type>

But it doesn't affect the config export.

atishgoswami commented 5 years ago

Hi @thaiphan,

Added PR #67 for this issue fix.

Regards, Atish

thaiphan commented 5 years ago

Everybody can take advantage of @atishgoswami's changes in the latest version of the extension. Thanks a lot!