search

thaiphan / magento2-s3

Use Amazon S3 as the file storage solution for your Magento 2 application
MIT License
142 stars 95 forks source link

Product image not showing on detail page #74

Open baljinderimpinge opened 5 years ago

baljinderimpinge commented 5 years ago

Hi

I have installed this module in my M2 store and have executed all the given commands in installtion it seems to be working for product list page but not on detail page. On product detail page there is no image or placeholder for the product. Can anyone suggest what is issue why I am facing this error.

Thanks

kin-allan commented 5 years ago

I'm facing the same issue. For the main image it works well, but for resized images it's not working correctly. Like: Admin Catalog List = Doesn't show Admin Product View = Show Frontend Catalog List =Show Frontend Product View = Doesn't appear.

Seems like the upload of the cached versions is failing in some requested, then it's generating inconsistently

dni commented 5 years ago

yes seeing the same issue, cached images starting to disappear, also bin/magento catalog:image:resize is failing after some time because images missing and not get synced

dni commented 5 years ago

@thaiphan any hints where to look or what may be the cause? maybe i can look into this.

baljinderimpinge commented 5 years ago

@thaiphan Can we have any update from your side?

thaiphan commented 5 years ago

Hey everyone,

It looks like Magento 2.3 changes the way images are resized, which my extension doesn't support yet.

Please hold tight as I implement changes (I also need to make sure any changes still work in older versions of Magento as well).

Regards,

Thai

sandip5678 commented 5 years ago

@thaiphan any hints where to look or what may be the cause? maybe i can look into this.

have you found any solution for the product detail page.

kin-allan commented 5 years ago

I see magento has an Observer running after product "save" (commit) that goes to the available view.xml and get the properties and resize using the framework/image. File: module-catalog/Observer/ImageResizeAfterProductSave.php Could be it?

sandip5678 commented 5 years ago

Hi Rigodrea, thanks for the response, but this will not work as this observer will call after the product save. here the issue is a little bit different, product image caching URL is not generating so that may be the reason.

jitunopal commented 5 years ago

@thaiphan Any suggestion from your side to resolve this issue? I am stuck here.

thaiphan commented 5 years ago

Sorry for taking so long everybody. I've been working non-stop and I'm also in the process of moving houses so life is super hectic for me!

dni commented 5 years ago

@thaiphan it's fine, thanks for your work, one thing though, do you have an estimation when you'll get it done? or do you need help?

thaiphan commented 5 years ago

@dni

Yeah it'd be great to get help on this!

I've already started on a fix on the branch: feature/fix-image-resize

Regards,

Thai

baljinderimpinge commented 5 years ago

Hello @thaiphan

When can we expect this issue to be resolved? Please update.

Thanks

seme1 commented 5 years ago

Any update on this ?

baljinderimpinge commented 5 years ago

It doesn't seems that anyone is looking on to the issue and its almost a month since I have raised the issue & still we are no where near to the solution.

dni commented 5 years ago

hey, guys, any status on this? my shop now had no images for months, i think i'm gonna uninstall the extension today, still looking forward for a fix.

@thaipan a status update on whats the problem would be very appreciated, is it just a time issue or is the fix difficult? i dont want to stress, i know you mentioned you are moving.

i dont have the time either to look deeper into the problem.

taoufiqaitali commented 5 years ago

any solution for cached images not being synchronized after products import???

niranjan-gondaliya commented 5 years ago

I'm facing the same issue. For the main image it works well, but for resized images it's not working correctly. Like: Admin Catalog List = Doesn't show Admin Product View = Show Frontend Catalog List =Show Frontend Product View = Doesn't appear.

Seems like the upload of the cached versions is failing in some requested, then it's generating inconsistently

Can you please enable SB storage and check for me it working.

php -f bin/magento s3:storage:enable

niranjan-gondaliya commented 5 years ago

Hello @thaiphan ,

Extession it working fine for Products image and Category image, But cache image not loading in Magento 2 frontend.

catalog/product/cache/aefcd4d8d5c59ba860378cf3cd2e94da/a/v/test.png

You have any idea ?

khasruch commented 5 months ago

Please check pub/media/.htaccess is deleted? you need to undo this. run this commend : git checkout pub/media/.htaccess