thaler-lab / Wasserstein

Python/C++ library for computing Wasserstein distances efficiently.
https://thaler-lab.github.io/Wasserstein
Other
21 stars 8 forks source link

ci: Use 'macos-13' runs-on to continue using x86 based macOS runners #16

Closed matthewfeickert closed 1 month ago

matthewfeickert commented 1 month ago

c.f. https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/ for additional context.

Related to Issue https://github.com/thaler-lab/Wasserstein/issues/13.

Doesn't address Issue https://github.com/thaler-lab/Wasserstein/issues/15, so Windows build will fail.

matthewfeickert commented 1 month ago

@j-s-ashley @rikab This is ready for review. This implements a guard that @henryiii added to Scikit-HEP projects a while back until people added Apple silicon support explicitly.

matthewfeickert commented 1 month ago

Example on my fork of things working sans Windows

image

henryiii commented 1 month ago

FYI, you can disable the cancellation of running jobs if there's an error:

strategy:
  fast-fail: false
  matrix:
    ...
matthewfeickert commented 1 month ago

FYI, you can disable the cancellation of running jobs if there's an error

Yeah, I usually leave fail-fast as true as to not just let all my linux jobs run on and on.