fix: Use snprintf over sprintf for security reasons

thaler-lab / Wasserstein

Python/C++ library for computing Wasserstein distances efficiently.

https://thaler-lab.github.io/Wasserstein

Other

21 stars 8 forks source link

fix: Use snprintf over sprintf for security reasons #17

Closed matthewfeickert closed 3 weeks ago

matthewfeickert commented 1 month ago

Resolves #14

Avoids:

warning: 'sprintf' is deprecated: This function is provided for compatibility
reasons only. Due to security concerns inherent in the design of sprintf(3),
it is highly recommended that you use snprintf(3) instead.

Use sizeof to determine the buffer size.

Requires PR #16 to go in first.

matthewfeickert commented 1 month ago

cc @rikab @henryiii @j-s-ashley this is ready for review.

@rikab as this is touching source code and not just build infrastructure it would be good to get an approval from you on it.

matthewfeickert commented 3 weeks ago

@j-s-ashley I think we can merge these in and then if there's concerns always revert (as it is a 1 commit PR that's easy to do, and we squash and merge anyway).