search

thaler-lab / Wasserstein

Python/C++ library for computing Wasserstein distances efficiently.
https://thaler-lab.github.io/Wasserstein
Other
21 stars 8 forks source link

build: Constrain numpy<2.0 #23

Closed matthewfeickert closed 4 weeks ago

matthewfeickert commented 4 weeks ago

Addresses part of Issue #22

I put these in manually instead of at the install_requires level

https://github.com/thaler-lab/Wasserstein/blob/f882b175946fd06c448e8b23151b25d50bbb54c8/setup.cfg#L71-L73

with the idea that this would be transitory and so not worth touching setup.cfg. That being said, as it would be a 1 line revert in setup.cfg, if this seems to be the better solution that's easy to adopt.

matthewfeickert commented 4 weeks ago

@j-s-ashley @henryiii this is ready for review.

henryiii commented 4 weeks ago

IMO install_requires would be fine. You don’t know how long the dep(s?) will take to update and if you need this, you are stuck with it as a public thing.

matthewfeickert commented 4 weeks ago

You don’t know how long the dep(s?) will take to update and if you need this, you are stuck with it as a public thing.

Yeah, sounds good. Fixed now.