fix: Remove numpy install from build wheel script env

thaler-lab / Wasserstein

Python/C++ library for computing Wasserstein distances efficiently.

https://thaler-lab.github.io/Wasserstein

Other

21 stars 8 forks source link

Closed matthewfeickert closed 4 weeks ago

matthewfeickert commented 4 weeks ago

NumPy should not be installed manually but as a build dependency it should be defined in the build-system requires in pyproject.toml.
Amends PR #23
Compliments PR https://github.com/thaler-lab/Wasserstein/pull/24 (should go in before PR #24 does and have PR #24 get rebased on top). This PR won't fix the delocate-wheel error that is being seen in the macOS wheel building, but it is a bit that needs to get cleaned along with PR #25, and PR #24.

matthewfeickert commented 4 weeks ago

@j-s-ashley this is ready for review and merge after the CI finishes.