search

thaliproject / CI

CI project for testing mobile devices
MIT License
2 stars 3 forks source link

Added handling for unauthorized/no permissions devices #36

Closed czyzm closed 8 years ago

czyzm commented 8 years ago

Handle unauthorized Android devices#32

This change is Reviewable

msftclas commented 8 years ago

Hi @czyzm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

vjrantal commented 8 years ago

tasker/android.js, line 41 [r1] (raw file): I'd edit the code still a little bit so that also the exact error gets logged. Otherwise, we don't see from the CI results which of the three the error was.

Comments from the review on Reviewable.io

czyzm commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

tasker/android.js, line 41 [r1] (raw file): In fact the error is logged. The previous solution with " OFFLINE" added was repeating the info that is already present in res[i]. The res array keeps entire lines of the adb devices output. Single line is device id and the status (offline, unauthorized, no permissions, ...). So you will get the error in the log.

Comments from the review on Reviewable.io

vjrantal commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io