thaliproject / CI

CI project for testing mobile devices
MIT License
2 stars 3 forks source link

getIOSDevices method in tasker/CI.js doesn't work when iOS has symbol ' #72

Open larryonoff opened 7 years ago

larryonoff commented 7 years ago

Problem Description

ios-deploy tool on command ios-deploy --detect --timeout 1 has the following example output.

[....] Waiting up to 1 seconds for iOS device to be connected
[....] Found iPhone 6s 'Ilya's iPhone' (1a1aa1a1111aa1a1a1a11aa1a1a1111aaaaa1a1a)

getIOSDevices parses this output to fetch device name and device identifier. But implementation of the parser is done so that it will have the following results:

device name Ilya
device identifier s iPhone' 1a1aa1a1111aa1a1a1a11aa1a1a1111aaaaa1a1a

As result ios-deploy tools run with invalid parameters, i.e.

ios-deploy -t 0 -9 -1 com.test.thalitest -i s iPhone' 1a1aa1a1111aa1a1a1a11aa1a1a1111aaaaa1a1a

Suggested Solution

  1. ios-deploy doesn't have parameter to provide with clean list of devices names and devices identifiers. So this function should be added PR, but output needs to be considered.
  2. update getIOSDevices method