search

thaliproject / CI

CI project for testing mobile devices
MIT License
2 stars 3 forks source link

Create CI smoke test #74

Closed yaronyg closed 8 years ago

yaronyg commented 8 years ago

A CI smoke test tells us that CI is working. It would:

  1. Run a simple native test on iOS and Android that just passes so we can confirm that we can call out to iOS and Android using our native test framework (executeNativeTest)
  2. Run a simple node test that uses the coordination server but just passes through set up, running the test and tear down to prove that the coordination server is configured and running properly
yaronyg commented 8 years ago

I think the right way to implement this is not as a magic branch but rather as a config parameter. What this would do is make sure that we are always testing with our latest code. Otherwise, for example, if we snapped a branch now it would have the old coordination server, not the new one that @andrew-aladev is writing.

So my suggestion is as follows:

  1. We should have a variable we can set to 'true' in build.sh that puts us in 'CI test mode'
  2. When this parameter is set then UnitTestConfig.js should have ios and android both set to -1 (e.g. we will override whatever the current setting is)
  3. When this parameter is set we should run a single test in executeNativeTests that is just a 'hello world' style automatic pass. It just shows that the native code was successfully deployed to the phone. That is all.
  4. When this parameter is set we should run a single test in Node, We should disable all the other tests. @artemjackson had a great example of this test here
  5. The node override in the previous step should apply to both desktop and device testing.
yaronyg commented 8 years ago

Marcin started working on this today. Currently blocked on thaliproject/CI#67

yaronyg commented 8 years ago

Script is written and now running tests in CI. Please talk to @andrew-aladev since you probably need to use the new test server to validate that coordination is actually working. @andrew-aladev can tell you which branch you should submit this fix to.

yaronyg commented 8 years ago

The code exists but the build is failing locally due to some issue with iOS that @mlesnic doesn't understand yet. He will talk with the iOS crew at Hiqo to get help.