#76 Better logging for CI

thaliproject / CI

CI project for testing mobile devices

MIT License

2 stars 3 forks source link

#76 Better logging for CI #78

Closed lesn1kk closed 8 years ago

lesn1kk commented 8 years ago

If it comes to iOS devices, as I looked through tasker/ios.js it has pretty good logging output, so for now I didn't make any changes. If it is not enough, I will try to make it better, just let me know.

This change is

msftclas commented 8 years ago

Hi @mlesnic, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

yaronyg commented 8 years ago

Please check the one non-blocking comment but otherwise

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

_tasker/android.js, line 201 at r1 (raw file):_

        if (str.length > 512) str = str.substr(0, 512);
        logme("Error: problem running Android apk(" + class_name + ") on device " + deviceName, str, "");
        //logme("Error: problem running Android apk(" + class_name + ") on device " + deviceName, str, "");

NB: Why is this comment here?

Comments from Reviewable