search

thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

Update mobile_test.json #1870

Closed jareksl closed 7 years ago

jareksl commented 7 years ago

As the configuration of the CI has changed, we need to update the mobile_test.json. The value of the key csname is used to upload generated test app to the test node and has to be consistent with 'Thali test' provisioning profile.

This change is Reviewable

ThaliTester commented 7 years ago

PR is added to the queue for testing as 1. task. (250d573)

ThaliTester commented 7 years ago

Test 121460753 (250d573) build started.

jareksl commented 7 years ago

a discussion (no related file): Please note that this PR contains also changes done within #1867 as it was not merged with the master yet. The only relevant part is the change in the mobile_test.json

Comments from Reviewable

ThaliTester commented 7 years ago

Test (Success) 121460753 build is completed (250d573)

See https://github.com/ThaliTester/TestResults/tree/121460753250d573_Update_mobile_test_json_jareksl/ for the logs

ThaliTester commented 7 years ago

Test 121460753250d573(250d573) has failed

See https://github.com/ThaliTester/TestResults/tree/121460753250d573_Update_mobile_test_json_jareksl/ for the fail logs

yaronyg commented 7 years ago

Please see comment about domain name.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

mobile_test.json, line 10 at r2 (raw file):

  "priority": "normal",
  "csname": {
    "android": "com.rockwellautomation.thalitest",

This can't be right. This is an open source project. It wouldn't do to make it specific to a particular company. If you would like you can of course use org.thaliproject.thalitest.

Comments from Reviewable