thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

Fix failing test on iOS devices #1871 #1872

Closed lesn1kk closed 7 years ago

lesn1kk commented 7 years ago

First of all, before starting this test we need to make sure that ThaliMobile is started. Otherwise, networkChangedNonTCP events will be filtered out.

Based on test assumptions that we discover 1 peer via WiFi and 1 peer via MPCF, we can safely assume that phone is connected to access point so the bbsidName field is set to some non null value. This is because networkChangedValue with bssidName set to null is treated same as WiFi off. See #1500 and #1707 for details.

Also, since this scenario assume that after disabling WiFi peerAvailabilityChanged event would be fired twice, we need to increase availibilityHandler calls limit by one.


This change is Reviewable

ThaliTester commented 7 years ago

PR is added to the queue for testing as 1. task. (8171119)

ThaliTester commented 7 years ago

Test 121958569 (8171119) build started.

ThaliTester commented 7 years ago

Test (Success) 121958569 build is completed (8171119)

See https://github.com/ThaliTester/TestResults/tree/1219585698171119_Fix_failing_test_on_iOS_devices__1871_mlesnic/ for the logs

ThaliTester commented 7 years ago

Test 1219585698171119(8171119) has failed

See https://github.com/ThaliTester/TestResults/tree/1219585698171119_Fix_failing_test_on_iOS_devices__1871_mlesnic/ for the fail logs

yaronyg commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

yaronyg commented 7 years ago
:LGTM:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

jareksl commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

enricogior commented 7 years ago
:lgtm:

Comments from Reviewable