search

thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

Specify and implement SSDP location validation #490

Open vjrantal opened 8 years ago

vjrantal commented 8 years ago
yaronyg commented 8 years ago

This bug is to make sure that when we get a location header over SSDP that the header can't point us in a random direction. We need to first off make sure it is not a DNS address since we should only be using SSDP for local discovery. Then we need to make sure it is a properly formed IPV4 or IPV6 address. Then ideally we would check the local subnet mask and make sure that the address is within that range. Although that last check makes me slightly nervous if the WiFi infrastructure is really fancy. The point of all this checking is to make sure that we don't get the kind of amplification attacks we saw with UPnP.