thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

We need to add greenkeeper support #731

Open yaronyg opened 8 years ago

yaronyg commented 8 years ago

I'm marking this as a bug because it will break us if we don't do this. I'm marking this as a security issue because it will keep us from getting security updates if we don't do this.

In order to deal with version conflicts that the semver rules in package.json allowed when using ^ or ~ I have had to switch our package.jsons to hard coding a specific version. This then means that we don't get updates, bug fixes, security fixes, etc. This is where Greenkeeper comes in. It will automatically submit PRs and run our tests whenever a dependency gets updated. We need this, badly!

Keep in mind that we actually have four different package.json files in our project and we need them all monitored.

artemjackson commented 8 years ago

@yaronyg we cannot use Greenkeeper with Thali_CordovaPlugin because of the current project structure. The project has multiple package.json files when Greenkeeper only supports single package.json and this package.json must be in the repo root.

Please see the solutions we assume:

yaronyg commented 7 years ago

https://github.com/boennemann/alle#readme

The above explains how PouchDB did it. Not all of it applies to us though.