search

thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

Should we switch from JSHint/JSCS to ESLint? #858

Open yaronyg opened 8 years ago

yaronyg commented 8 years ago

All the cool kids are doing it and apparently the JSCS plugin for ATOM causes ATOM to hang.

iserzh commented 8 years ago

@yaronyg I think this issue (https://github.com/AtomLinter/linter-jscs/issues/241) is enough to move to ESLint.

yaronyg commented 8 years ago

We really want to move but we just don't have time right now to figure out the rules. Once we get the iOS native release done then we can evaluate this. But I do agree, a 100% cpu/never going to be fixed bug is a big motivator to move. I will at least kick this into backlog and mark it as a bug.

yaronyg commented 8 years ago

I created a .eslintrc file and used polyjuice to translate our .jscsrc and .jshintrc files into the .eslintrc file but who knows how the good the translation is and anyway eslint has its own rules. So we really need to do a walk through review to pick the settings that best meet our needs.