search

thaliproject / Thali_CordovaPlugin

Thali p2p plugin
MIT License
226 stars 44 forks source link

Wrong calculation of succeed tests in TestRunner #923

Open baydet opened 8 years ago

baydet commented 8 years ago

At this moment TestRunner uses this logic to calculate succeedCount

succeededCount += Int(testRun.executionCount - testRun.failureCount)

But it's not correct since failureCount stores number of failed assert checks. For example we have 1 test with 3 XCTAssert checks. In this case succeededCount will have negative value

larryonoff commented 8 years ago

The fix is implemented, but we need add tests.