Closed faisal-hameed closed 8 years ago
Hi @faisal-hameed, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.
TTYL, MSBOT;
@faisal-hameed, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;
This 'mistake' was actually intentional. I really hate '!' as it is way too easy to misread. But I also realize that I'm fighting the universe and I need to stop. So oh well.
Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
_Comments from Reviewable_
This pull request is focused on resolving occurrences of Sonar rule squid:S1125 - Literal boolean values should not be used in condition expressions. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1125
Please let me know if you have any questions.
Faisal Hameed
This change is![Reviewable](https://reviewable.io/review_button.svg)