General code quality fix-1

thaliproject / Tor_Onion_Proxy_Library

Provides a JAR and an AAR for embedding the Tor Onion Proxy into a Java or Android Program

Apache License 2.0

179 stars 98 forks source link

General code quality fix-1 #44

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". squid:S128 - Switch cases should end with an unconditional "break" statement. You can find more information about the issues here: https://dev.eclipse.org/sonar/rules/show/squid:S2583 https://dev.eclipse.org/sonar/rules/show/squid:S128

Please let me know if you have any questions.

Faisal Hameed

This change is

msftclas commented 8 years ago

Hi @faisal-hameed, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@faisal-hameed, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

yaronyg commented 8 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

_Comments from Reviewable_