Closed deadlyfingers closed 8 years ago
www/jxcore/public/elements/page-editor/page-editor.html, line 128 [r2] (raw file): Is context really needed here?
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-home/page-home.html, line 132 [r2] (raw file): Once again, is context needed? We're not using it in any of our callbacks
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-editor/page-editor.html, line 137 [r2] (raw file): Unless we're using any of the variables, it's not necessary to declare any of these variables
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-editor/page-editor.html, line 139 [r2] (raw file): Unless we're using all of the variables such as textStatus and jqXHR, it's not necessary to declare them
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-home/page-home.html, line 135 [r2] (raw file): Same applies here from above, if not using the variables, no bother to declare them
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-home/page-home.html, line 137 [r2] (raw file): Same comment as above, if not using textStatus and jqXHR, no need to declare them
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-home/page-home.html, line 297 [r2] (raw file): same nitpick as above with unused variables
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-home/page-home.html, line 300 [r2] (raw file): same nitpick as above with unused variables
Comments from the review on Reviewable.io
www/jxcore/public/elements/page-login/page-login.html, line 54 [r2] (raw file): Same nitpick as above
Comments from the review on Reviewable.io
David is just testing
Put in a description of how to fix the cordova plugin and release.
It seems to be working? He needs to run through the run through the readme.
Tested on iOS 8 devices - iPhone 5S and iPhone 6. Also works on iOS 9 with App Transport info.plist fix. Tested on Android L devices - Moto G (2nd Gen) with 5.0.2 and Xperia with 5.0.
Updates only changes (delete, update or create) to close #45. Removes reload button to close #31.