search

thaliproject / postcardapp

A sample app to demonstrate how to build Thali applications
MIT License
22 stars 5 forks source link

Connect identity exchange UX to REST back end #51

Closed yaronyg closed 8 years ago

yaronyg commented 8 years ago

We need the existing identity exchange UX which is talking to a mock of the REST backend for identity exchange to talk to the real thing.

yaronyg commented 8 years ago

10/21 - Was spent on solidifying story 0 and now just moving to story 0.0.1.

yaronyg commented 8 years ago

10/30 - Will start working on this (finally!) today!!!! First step is to merge thali_cordovaplugin 0.0.1 into the postcard app.

yaronyg commented 8 years ago

11/2 - Just starting to work on some issues with the mock UX and working with the REST API.

deadlyfingers commented 8 years ago

Reworking user login from story_0 to story_001 spec.

It it okay to call webview/DeviceIdentity at app launch without stopping TRM - this procedure is just needed while webview/IdentityExchange is running?

yaronyg commented 8 years ago

Yes, it's fine. You should be able to call DeviceIdentity at any time. If not then we have a bug.

deadlyfingers commented 8 years ago

Getting a 400 error when trying to pair atm 

ExecuteExchange peerDeviceId:F8:CF:C5:7A:32:6A
http://localhost:5000/webview/IdentityExchange/ExecuteExchange Failed to load resource: the server responded with a status of 400 (Bad Request)
page-pair.html:112 Error, could not Execute Exchange. error

Update: working now - was using a different case!

deadlyfingers commented 8 years ago

Potentially found another issue to raise? As we will be using the DK-hash as Id for Postcards the value needs to support REST. Sometimes the hash contains '/' or other invalid characters which results in a 404 error as the url thinks its a dir and can't resolve it as a PouchDB filename Id.

Also means I can't save the contact if their DK-hash contains a slash '/' char.

yaronyg commented 8 years ago

11/9 - working but we have to get it working with #55

yaronyg commented 8 years ago

11/9 - Needs some finishing, hoping for PR on 11/10.

deadlyfingers commented 8 years ago

@mattpodwysocki peerFriendlyName seems to duplicate on requests?

I/jxcore-log( 2048): INFO identityExchange We will advertise the following device name as we start: /X8v+Cl+Q8+UhCPbyXi07Q==;sony
I/jxcore-log( 2048):
I/jxcore-log( 2048): INFO identityExchange We will advertise the following device name as we start: /X8v+Cl+Q8+UhCPbyXi07Q==;sony;sony
yaronyg commented 8 years ago

@deadlyfingers please follow up with @mattpodwysocki , this looks like a pretty straight forward bug.

deadlyfingers commented 8 years ago

Couple of things to review: