mpodwysocki
commented
8 years ago Review status: 0 of 6 files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.
www/jxcore/app.js, line 23 [r1] (raw file): Instead of just logging it, shouldn't this be a fatal error and we just crash?
www/jxcore/cardroutes.js, line 11 [r1] (raw file): Instead, use res.status(400).json({ error: 'Username is undefined' })
www/jxcore/cardroutes.js, line 16 [r1] (raw file): If you're already trimming above, why do it again?
www/jxcore/cardroutes.js, line 17 [r1] (raw file): Instead, use res.status(400).json({ error: 'Username is required' })
www/jxcore/package.json, line 11 [r1] (raw file): why are we pegging it to a release instead of saying ^1.4.1 which says upwards of 1.4?
www/jxcore/package.json, line 13 [r1] (raw file): Same applies to this, why are we pegged at only 5.0.0 instead of ^5.0.0 and upwards?
Comments from the review on Reviewable.io
deadlyfingers
Minor update to fix first run issues on Android and iOS for story_0