Closed larryonoff closed 8 years ago
msftclas
commented
8 years ago Hi @larryonoff, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;
yaronyg
commented
8 years ago The links are wrong. The correct format would have been, for say issue 417, as https://github.com/thaliproject/Thali_CordovaPlugin/issues/417
And note that this is trickier than it looks as not all the issues are in the same repo. For example, issue 4 in the salti library has the URL https://github.com/thaliproject/salti/issues/4
I can't imagine this is worth the time to fix so I would suggest just abandoning this PR.
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.
_Comments from Reviewable_
larryonoff
commented
8 years ago I updated links format.
I think that it's better merging this PR if format is fine, because it's better having some links broken and fix them later that just not having them. It's really difficult going thru the list of the issues without any links.
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
yaronyg
commented
8 years ago You need to use absolute URIs so the link will work both on GitHub and on our website.
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.
Comments from [Reviewable](https://reviewable.io:443/reviews/thaliproject/thali/275#-:-KRzraxIst4KKZfRLGJ:bsi4pwi)_
yaronyg
commented
8 years ago 
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Getting to new infra blog post updated with links into issues.
PS. I'm not sure that I added links properly.
This change is