search

thaljef / Pinto

Curate your own repository of Perl modules
https://metacpan.org/module/Pinto::Manual
66 stars 49 forks source link

Avoid dependency loops in roots command #160

Closed mar-kolya closed 10 years ago

mar-kolya commented 10 years ago

Current implementation of roots command will ignore all packages in dependency loop because each of them is a dependence of another package

This change fixes this by breaking loop.

thaljef commented 10 years ago

As discussed in #158, the roots command might be doomed. So I'm going to put this pull request on hold until I figure out what to do about the command.

thaljef commented 10 years ago

Per discussion in #158, the roots command really is doomed. There's just no way for pinto to reliably determine what your "root" dependencies are.

So I'm going to reject this pull request. The roots command will be deprecated in the next release, and then removed in a subsequent release.