No error message from Pinto 0.09994 when talking to an older server.

thaljef / Pinto

Curate your own repository of Perl modules

https://metacpan.org/module/Pinto::Manual

66 stars 49 forks source link

No error message from Pinto 0.09994 when talking to an older server. #161

Closed hartzell closed 10 years ago

hartzell commented 10 years ago

The Changes file for 0.09994 says

But for the time being, you'll get an exception telling you whether to upgrade your client (pinto) or the server (pintod).

I installed 0.09994 today, talking to a version 0.0998 server and got a silent failure (non-zero error status but no error message).

georgewh@rescomp232:pinto>pinto -r http://gpan.gene.com:5000 list
georgewh@rescomp232:pinto>echo $?
1
georgewh@rescomp232:pinto>

When I restarted the server things worked as they should.

thaljef commented 10 years ago

I can't reproduce. When I use that combination of client and server, I get this ugly (but accurate) exception:

HTTP/1.0 500 Internal Server Error
Date: Tue, 03 Jun 2014 21:18:54 GMT
Server: HTTP::Server::PSGI
Content-Type: text/plain; charset=utf-8
Content-Length: 11716

Found unknown attribute(s) passed to the constructor: color palette at ....

thaljef commented 10 years ago

Older versions of Pinto::Server have no code to check the protocol version, so they won't report any versioning errors at all. I can't change code that is already released, so this may be unfixable. I will try to improve the description in the change log.