search

thaljef / Pinto

Curate your own repository of Perl modules
https://metacpan.org/module/Pinto::Manual
66 stars 49 forks source link

Test suite should not fail for perl RCs #167

Closed eserte closed 9 years ago

eserte commented 10 years ago

Currently Pinto is failing for perl 5.20.1-RC1, see http://matrix.cpantesters.org/?dist=Pinto;perl=5.20.1;reports=1 and http://www.cpantesters.org/cpan/report/1ff98328-2ce2-11e4-acd9-5052e0bfc7aa

Probably this is due to Module::CoreList not containing this version of perl. Nevertheless it would be nice to have this test not failing. Maybe you could use code like this

perl5.20.1-RC1 -MConfig -e 'if (grep { $_ =~ m{^RC\d+$} } Config::local_patches()) { warn "This is a RC" }'

and skip this test in case of a RC?

eserte commented 10 years ago

The problem is slightly different. The whole story is in https://rt.perl.org/Ticket/Display.html?id=122670

thaljef commented 9 years ago

The whole story is in https://rt.perl.org/Ticket/Display.html?id=122670

It sounds like this has been resolved. So hopefully, all future releases of Perl (including release candidates) will have the appropriate version of Module::CoreList. If that is true, can I close this issue?

eserte commented 9 years ago

I think so.