bin/pinto --version returns non-zero exit status

thaljef / Pinto

Curate your own repository of Perl modules

https://metacpan.org/module/Pinto::Manual

66 stars 49 forks source link

bin/pinto --version returns non-zero exit status #215

Open bigunyak opened 9 years ago

bigunyak commented 9 years ago

While puppetising Pinto installation I stumbled on bin/pinto --version command returning non-zero exit status code which indicates failure and puppet stops the deployment. I went around this by setting returns parameter for exec resource, but it's just doesn't look nice. Could you please fix this small issue. I guess it's related to #132 but I decided to open a fresh ticket.

thaljef commented 8 years ago

This exit status comes from App::Cmd which provides the --version functionality. @rjbs, do you have an opinion on the exit status of --version (and presumably --help as well)?

rjbs commented 8 years ago

~$ dzil --version
dzil (Dist::Zilla::App) version 6.006 (/Users/rjbs/.plenv/versions/24.0/bin/dzil)
~$ echo $?
0

…and I get the same with other App::Cmd-based things. I don't think this is App::Cmd's doing alone.