search

thaljef / Pinto

Curate your own repository of Perl modules
https://metacpan.org/module/Pinto::Manual
66 stars 49 forks source link

Add workaround for Term::ReadKey >= 2.37 #241

Closed mschout closed 6 years ago

mschout commented 7 years ago

As of Term::ReadKey v2.34, Pinto was unable to pull this module. In v2.37, the author added Term::ReadKey to the "provides" section of META.yml. This workaround fixes can_index() so that Pinto is able to index Term::ReadKey 2.37 or later.

Fixes #240

thaljef commented 7 years ago

Hi Michael, sorry for the long wait on this. The metadata for Term::ReadKey seems broken to me. I can't think of a reason why the metadata should say that META.yml is the file that provides the package. I'll open a ticket with the author to get an explanation.

mschout commented 7 years ago

thanks

hartzell commented 6 years ago

I left a comment over in jonathanstowe/TermReadKey#29 about this, I believe that the fix in the PR should be generalized for any case where the file is META.{json,yaml}.

@mschout -- are you up for that or should I swing at it?

hartzell commented 6 years ago

Alternatively, a cleaner change might be to touch up is_simile so that it considers META.{yaml,json} to be a simile for any module that uses it as it's file attribute.

mschout commented 6 years ago

@hartzell I'll update my workaround today with your suggestions. Thanks

mschout commented 6 years ago

I removed the Term::ReadKey hack, and fixed it in is_simile as suggested. I also added a test case.

mschout commented 6 years ago

It appears Travis-CI is broken (fails to fetch Dist::Zilla). All tests pass on my machine

thaljef commented 6 years ago

Merged. Thanks. I'll fix the Travis problems on the master branch.