thamara / improved-bga-game-info-extension

See more information about a game in its page on BGA.
4 stars 2 forks source link

Details provided by extension only load after refreshing the game panel once #1

Closed tupaschoal closed 3 years ago

tupaschoal commented 3 years ago

I just installed the extension (tip https://github.com/thamara/improved-bga-game-info-extension/commit/ba7dbcaa564406e515c62f412e2efc04aa31e3a3) and went to try it out. Somehow the details it adds only appear after refreshing the game page once, as shown on the gif below:

bug_chrome

If I return to BGA's homepage and go into the same game again after this gif, the bug occurs again, consistently.

thamara commented 3 years ago

Were you running other browsers? Or more than one window of chrome?

tupaschoal commented 3 years ago

Just one browser for sure, but I don't remember if it had multiple windows (probably not)

thamara commented 3 years ago

I thought I have fixed it, at least I could not reproduce it unless if I have edge or firefox also open, which is really weird. But I'll try again later.

tupaschoal commented 3 years ago

Happens consistently on Chrome (only web browser open) with just one tab!

thamara commented 3 years ago

Thanks for confirming. I'll try to look at it.

thamara commented 3 years ago

I expect this to be fixed now. The issue was that BGA uses something (which I don't know the name, nor I can explain it well) that going from some pages to the game information page is not counted as "new page", and the script was being added only on such "new page" events. Now I'm listening to those push changes and run the script.

Can you please try again? I have tested in Chrome, Edge and Firefox and it's working here.

tupaschoal commented 3 years ago

Tested it here and seems like it's solved now :)

thamara commented 3 years ago

Yay! Thanks!