search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

Bumped ecma version on eslint #1019

Closed gsriram24 closed 1 year ago

gsriram24 commented 1 year ago

Related issue

Closes #1010

Context / Background

The issue of ESLint throwing an error with the nullish coalescing operator has been resolved by bumping up the ecmaVersion to 2020.

What change is being introduced by this PR?

The ecmaVersion in the .eslintrc.json has been changed to 2020 instead of 2018.

How will this be tested?

Run npm run lint to check if the issue persists.

gsriram24 commented 1 year ago

Thanks @gsriram24! Can you please revert all the formatting changes and keep only the bump up to 2020, please?

Could you please check now?

araujoarthur0 commented 1 year ago

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1019 (97cc4ca) into main (e25523f) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   75.04%   75.04%           
=======================================
  Files          26       26           
  Lines        2188     2188           
  Branches      345      345           
=======================================
  Hits         1642     1642           
  Misses        546      546
gsriram24 commented 1 year ago

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

The change in changelog.md is made by npm run lint-fix. I cannot commit without making that change as the precommit hook fails.

tupaschoal commented 1 year ago

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

The change in changelog.md is made by npm run lint-fix. I cannot commit without making that change as the precommit hook fails.

There's a way to workaround it, but nvm

BamButz commented 1 year ago

Is there anything left, that blocks this PR from getting merged? It seems to be corrected and ready to merge from my sight.

gsriram24 commented 1 year ago

Is there anything left, that blocks this PR from getting merged? It seems to be corrected and ready to merge from my sight.

I think we can get it merged, nothing is left.

araujoarthur0 commented 1 year ago

\changelog-update