thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
450 stars 265 forks source link

Checking lint in PR CI checks #1023

Closed BamButz closed 8 months ago

BamButz commented 8 months ago

Related issue

Closes #987

Context / Background

As described in the issue, I added linting to the CI checks to avoid introduction of linting faults.

What change is being introduced by this PR?

Checks workflow now checks for linting issues.

PR #1019 should be merged first to fix some lint errors.

BamButz commented 8 months ago

I will rebase as soon as #1019 is merged in, that should fix the checks.

araujoarthur0 commented 8 months ago

@BamButz now it should be ok

BamButz commented 8 months ago

Changelog Bot does not comply with your linting rules: see commit 322a4d3

araujoarthur0 commented 8 months ago

Yes :( saw that earlier today #1027

araujoarthur0 commented 8 months ago

Think that might be a blocker otherwise every PR will restart the issue.

araujoarthur0 commented 8 months ago

Can you try now again to rebase? It might have been a problem only when the file had no changes for a release - it is no longer empty.

codecov[bot] commented 8 months ago

Codecov Report

Merging #1023 (7c9f09c) into main (ae757ab) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files          26       26           
  Lines        2202     2202           
  Branches      346      346           
=======================================
  Hits         1654     1654           
  Misses        548      548           
araujoarthur0 commented 8 months ago

\changelog-update