search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

fix: make images and icons not draggable #1025

Closed Karroteu closed 11 months ago

Karroteu commented 1 year ago

Makes images and icons not draggable within the app

Related issue

Closes #1028

Context / Background

Makes images and icons with class .th and logo not draggable within the app

What change is being introduced by this PR?

Slight UX improvement

How will this be tested?

No need for testing, has little impact on usability of the app, though I've tested it locally

araujoarthur0 commented 1 year ago

Hi @Karroteu, this look like an interesting improvement! Could you please ensure you create a bug for tracking before submitting a PR?

Also, please revert the changes in package lock since they don't seem related.

Karroteu commented 1 year ago

Sorry i didn't mean to delete the file. I'm new to this. Would you be able to revert the change please? I'e created an issue for this pull request but im unable to assign it to this pr @araujoarthur0

araujoarthur0 commented 1 year ago

You can assign the issue by editing the description and adding a "Closes #" string to it. You can check other PRs to see it being done.

Also, to revert this change you can use git reset --soft HEAD~ to undo the last commit, unstage the change and then commit again. After that you can git push --force this branch to replace the changes here.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e25523f) 75.04% compared to head (76edc70) 79.37%. Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1025 +/- ## ========================================== + Coverage 75.04% 79.37% +4.32% ========================================== Files 26 21 -5 Lines 2188 1275 -913 Branches 345 189 -156 ========================================== - Hits 1642 1012 -630 + Misses 546 263 -283 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tupaschoal commented 11 months ago

\changelog-update Message: Fix [#1028]: Make images and icons not draggable