Closed araujoarthur0 closed 1 year ago
Merging #1035 (aab44ac) into main (3f7076e) will increase coverage by
4.34%
. Report is 4 commits behind head on main. The diff coverage is25.58%
.
@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 75.02% 79.37% +4.34%
==========================================
Files 26 21 -5
Lines 2202 1275 -927
Branches 346 189 -157
==========================================
- Hits 1652 1012 -640
+ Misses 550 263 -287
Files | Coverage Δ | |
---|---|---|
js/time-balance.js | 100.00% <ø> (ø) |
|
js/user-preferences.js | 100.00% <100.00%> (ø) |
|
js/window-aux.js | 100.00% <100.00%> (ø) |
|
js/main-window.js | 73.50% <87.50%> (+0.46%) |
:arrow_up: |
js/menus.js | 81.73% <50.00%> (ø) |
|
src/calendar.js | 0.00% <0.00%> (ø) |
\changelog-update Message: Enhancement [#646]: Title bar color now follows Windows mode (dark or light)
Related issue
Closes #646
Context / Background
Updating electron to a newer version than 12 :)
What change is being introduced by this PR?
require()
statements would stop working.@electron/remote
. This requires initialization in main process, which for renderer tests is done in the jest rpc patch.electron-store
package v6 stopped working because it required the old remote. Upgrade to latest, which now requires an initialization step in main just like above.sender
member in our tests, which went away. Had to remove the line in the tests.How will this be tested?
Ran the app locally, all tests are also passing. Also testing the release flow in https://github.com/araujoarthur0/time-to-leave/actions/runs/6745696311