Closed tupaschoal closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
26066c4
) 79.37% compared to head (95e521b
) 79.40%. Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tupaschoal looks like the tests failed
@araujoarthur0 should be fine now, since we changed the way that win32 notifications are created, I needed to check different notification parameters for the tests
\changelog-update Message: Fix #1039: Use toast notification syntax to support actions on Win32
\changelog-update Message: Fix [#1039]: Use toast notification syntax to support actions on Win32.
Context / Background
@ochan12 had kindly introduced the more modern notification syntax for Win32 when we eventually upgraded electron
What change is being introduced by this PR?
Updating the notification syntax, fixing some of the code that was previously there. For some reason, the button text only works if the variable is assigned first:![image](https://github.com/thamara/time-to-leave/assets/6443427/a7372f88-9803-4e1d-a584-20c4ab3bb832)
How will this be tested?
Tested it locally, but I'm not 100% sure it works