thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
450 stars 265 forks source link

Use toast notification syntax to support actions on Win32 #1039

Closed tupaschoal closed 7 months ago

tupaschoal commented 7 months ago

Context / Background

@ochan12 had kindly introduced the more modern notification syntax for Win32 when we eventually upgraded electron

What change is being introduced by this PR?

Updating the notification syntax, fixing some of the code that was previously there. For some reason, the button text only works if the variable is assigned first: image

How will this be tested?

Tested it locally, but I'm not 100% sure it works

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (26066c4) 79.37% compared to head (95e521b) 79.40%. Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1039 +/- ## ========================================== + Coverage 79.37% 79.40% +0.03% ========================================== Files 21 21 Lines 1275 1277 +2 Branches 189 189 ========================================== + Hits 1012 1014 +2 Misses 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

araujoarthur0 commented 7 months ago

@tupaschoal looks like the tests failed

tupaschoal commented 7 months ago

@araujoarthur0 should be fine now, since we changed the way that win32 notifications are created, I needed to check different notification parameters for the tests

araujoarthur0 commented 7 months ago

\changelog-update Message: Fix #1039: Use toast notification syntax to support actions on Win32

tupaschoal commented 7 months ago

\changelog-update Message: Fix [#1039]: Use toast notification syntax to support actions on Win32.