Closed araujoarthur0 closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8f2ae80
) 80.00% compared to head (9b9c47b
) 81.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems fine, actually easier than I thought, dependency changes aside, but I think that's because time-math has no stubs/mocks, right?
Yes, I chose the simplest one to get it along with the infrastructure changes 🤣
Related issue
Helps #1037
Context / Background
Refer to #1054. Here I'm starting to migrate our tests to the electron-mocha infrastructure, which works well with ES6 modules. I think I'll only be able to pre-migrate the ones that don't depend on jest-specific things, before switching fully to ES6. Starting with the simple test tests/main/time-math.js as an example here.
What change is being introduced by this PR?
@babel/plugin-transform-modules-commonjs
is used to convert ES6 into common js while we don't move fully to ES6.c8
dependency, which has the same purpose asnyc
, that of a code coverage runner around mocha. Had to use this one because nyc doesn't work with electron-mocha. Anyway, c8 is considered the native replacement to nyc, and the output is exactly the same."test:electron-mocha-main"
, which is used in the test pipeline.How will this be tested?
Pipeline passes in the same way, coverage will be coming from two reports and is currently being merged into a single report. CodeCov is properly parsing the combination.