thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
450 stars 265 forks source link

Migrating the functional mocha test from Spectron to PlayWright #1062

Closed araujoarthur0 closed 3 months ago

araujoarthur0 commented 5 months ago

Related issue

Helps #1037, Closes #653

Context / Background

The mocha test we had was using Spectron, which has sadly been deprecated. The new suggestion the Electron team made is to use PlayWright. Thus I'm migrating the test to it.

What change is being introduced by this PR?

How will this be tested?

Test is passing fine now.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.81%. Comparing base (b3fd77f) to head (ac0bf42).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1062 +/- ## =========================================== - Coverage 81.79% 56.81% -24.98% =========================================== Files 22 22 Lines 1401 3270 +1869 Branches 214 419 +205 =========================================== + Hits 1146 1858 +712 - Misses 255 1412 +1157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

araujoarthur0 commented 4 months ago

I think we'll have to accept that the coverage report will not be properly done with c8 and esm #34. There doesn't seem to be any workaround either.

araujoarthur0 commented 3 months ago

@tupaschoal what do you think?

tupaschoal commented 3 months ago

I think that's fine @araujoarthur0