search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
460 stars 270 forks source link

Reinforce param order in Calendar.js #385

Closed araujoarthur0 closed 4 years ago

araujoarthur0 commented 4 years ago

Describe the current limitation Multiple methods from Calendar.js follow a different param ordering. Some have "year, month, day", others have "day, month, year".

Describe the proposed feature or enhancement Let's make this consistent :) I'm pushing for year, month, day, since that's the format the DB is working with. @thamara do you agree?

araujoarthur0 commented 4 years ago

Whoever picks this, please wait till https://github.com/thamara/time-to-leave/pull/384 is approved, as you'll have to fix the docblocks too :) hahaha

parnus01 commented 4 years ago

@araujoarthur0 Hi i will do this issue, please help to assign.

araujoarthur0 commented 4 years ago

It's assigned :)