search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
455 stars 268 forks source link

Localization action is broken somehow #829

Open thamara opened 2 years ago

thamara commented 2 years ago

In https://github.com/thamara/time-to-leave/pull/828 the Localization action is broken. This action is used to compare if new strings are added or any inconsistency on the localization files.

Run: https://github.com/thamara/time-to-leave/runs/5490690174?check_suite_focus=true

ochan12 commented 1 year ago

I think is because the action is configured to run on pull_request so secrets are not sent to forked repos, as said here. On PRs coming from own repo seems to work.

It could be changed to pull_request_target so the context comes from the base branch and not forked one

tupaschoal commented 1 year ago

That's a good point, maybe we should try that @thamara

araujoarthur0 commented 1 year ago

Disabled the action to stop having failed runs on every PR.

araujoarthur0 commented 1 year ago

Like ochan12 said, seem this was documented in the action repo:

create-or-update-comment@v2

Note: In public repositories this action does not work in pull_request workflows when triggered by forks. Any attempt will be met with the error, Resource not accessible by integration. This is due to token restrictions put in place by GitHub Actions. Private repositories can be configured to enable workflows from forks to run without restriction. See here for further explanation. Alternatively, use the pull_request_target event to comment on pull requests.