Closed Harmonygrams closed 1 year ago
Hi @Harmonygrams, can you please tend to the comments made by @araujoarthur0 ?
What am I suppose to do? @tupaschoal
Arthur has left 4 comments on the code about changes to be made
Okay. I'd do just that. Thank you @tupaschoal
Nice, let us know when you do. Also note you have a merge conflict that needs solving.
I have made all changes but I can't since it's return error duplicate selector in the styles.css file
Have you rebased or merged your branch onto the most recent main?
Yes. I'm trying to merge but it's asking me to commit changes first. I want to undo everything, pull the code all over again and make changes to only the affected files.
Do you need help? You can go over to our discord.
Related issue
Closes # On macOS, icon on tray is huge! #888
Context / Background
I fixed the MacOs huge icon tray issue
What change is being introduced by this PR?
How did you approach this problem? First, I read the electron documentation and discovered that for for high resolution icons on macOS operating systems, it's best to use 16x16 dimensions or 32x32 dimensions .png images with @x2 at the end of their base name.
What changes did you make to achieve the goal? I compressed the dimensions of the tray image without affecting the image quality. I changeed the dimension from 128x128 diemension to 32x32 dimension. I also changed the names of the images from ttl.png to ttl@2x.png I made a little changes to the appConfig object in app-config.js file module by changing the value of the iconpath from '../assets/ttl.png' to '../assets/ttl@2x.png'
How will this be tested?
I ran the test by executing the code before and after modifying the code and no problems were found. npm run test:jest