thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

Big icon tray #894

Closed Harmonygrams closed 1 year ago

Harmonygrams commented 2 years ago

Related issue

Closes # On macOS, icon on tray is huge! #888

Context / Background

I fixed the MacOs huge icon tray issue

What change is being introduced by this PR?

How will this be tested?

I ran the test by executing the code before and after modifying the code and no problems were found. npm run test:jest

tupaschoal commented 2 years ago

Hi @Harmonygrams, can you please tend to the comments made by @araujoarthur0 ?

Harmonygrams commented 2 years ago

What am I suppose to do? @tupaschoal

tupaschoal commented 2 years ago

Arthur has left 4 comments on the code about changes to be made

Harmonygrams commented 2 years ago

Okay. I'd do just that. Thank you @tupaschoal

tupaschoal commented 2 years ago

Nice, let us know when you do. Also note you have a merge conflict that needs solving.

Harmonygrams commented 2 years ago

I have made all changes but I can't since it's return error duplicate selector in the styles.css file

araujoarthur0 commented 2 years ago

Have you rebased or merged your branch onto the most recent main?

Harmonygrams commented 2 years ago

Yes. I'm trying to merge but it's asking me to commit changes first. I want to undo everything, pull the code all over again and make changes to only the affected files.

tupaschoal commented 2 years ago

Do you need help? You can go over to our discord.