Fix #896: fallbackLng should be English - Githubissues

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.

http://timetoleave.app

GNU General Public License v3.0

463 stars 271 forks source link

Fix #896: fallbackLng should be English #898

Closed sisir-umich closed 1 year ago

sisir-umich commented 2 years ago

Related issue

Closes #896

Context / Background

Made the minor change suggested in issue #896 as a way to try out a contribution and observe the pr/code review system for the project.

What change is being introduced by this PR?

How did you approach this problem? I searched for the "fallbackLng" variable in the code base to see where the change was needed.
What changes did you make to achieve the goal? I changed "es" to "en" as suggested in the issue.
What are the indirect and direct consequences of the change? The fallback language should be English now.

How will this be tested?

I ran npm run test:jest after the change, and all the tests passed.

[ ] I confirm I'm a native or fluent speaker of the language I'm translating to.

araujoarthur0 commented 2 years ago

Made a comment in the issue.