Fix #892: Fix start menu entry title on Windows

[show981111]

Related issue

Issue #892

Context / Background

Start menu entry for Windows is time-to-leave, not "Time to Leave"

What change is being introduced by this PR?

1) When using an electron package manager, I changed the app name from "time-to-leave" to "Time to Leave". This changed the application name inside the release-build from "time-to-leave" to "Time to Leave."

How will this be tested?

1) Run npm run package:win, and go to the release-builds folder. You will see "Time to Leave" application not "time-to-leave" 2) Then run npm run setup:win in packages/ there will be a setup.exe file. If you install Time to Leave with this file, you will get Time to Leave as a start menu entry

[show981111]

Can you please add an image showing it on the windows menu after your change?

I am not sure how to build setup.exe but this is what you see after you build a package for windows.

[araujoarthur0]

Can you please add an image showing it on the windows menu after your change?

I am not sure how to build setup.exe but this is what you see after you build a package for windows.

I believe there is an npm rule that does the packaging. Can you check the rules in package.json?

[show981111]

I believe there is an npm rule that does the packaging. Can you check the rules in package.json?

I checked the package.json script and looks like npm run package:win is the correct one. Also, the releasing documentation said npm run package:win will create an executable application, and the application you get after running this command is the one in the photo I posted above.

[codecov[bot]]

Codecov Report

Merging #901 (f4da05b) into main (f9a9f10) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files          17       17           
  Lines        1755     1755           
  Branches      278      278           
=======================================
  Hits         1254     1254           
  Misses        501      501           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[show981111]

The exe is just one part. The original issue mentions the name of the app when installed on Windows itself.

I can't test if this patch fixes it or not, because the release steps on it do not work after this change, since it changes the folder from release-builds\time-to-leave-win32-ia32\ to release-builds\Time to Leave-win32-ia32\ and npx electron-installer-windows stops working

I was able to fix it by adding the arguments on npx electron-installer-windows
I am not sure what arguments we are using currently, but it seems like the name of the start menu follows the name of the folder. I tried various options in electron-installer-windows but it did not work, but it worked after I changed the folder name.

I added the working command line in package.json. You can test this by running npm run setup Below is the image of start menu.

[araujoarthur0]

Can you please update the title now that you separated the css change?

[tupaschoal]

\changelog-update Message: Fix [#892]: start menu entry title on Windows is hyphenated