search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 271 forks source link

Remove Time to Leave string from translations and hard-code instead #912

Closed SarahRemus closed 1 year ago

SarahRemus commented 2 years ago

Describe the current limitation At the moment, the Time to Leave string is part of the translations. In particular, it concerns these cases:

This can cause potential errors in the translation when the translator is translating the time-to-leave string as well (which should not be the case). It happened before in issue #861 where the title was translated in Hindi and Gujarati.

Describe the proposed feature or enhancement I propose to remove the Time to Leave string from the translation and hard-code it instead. I'm not sure how this can be solved, maybe we need to make changes to the translation function, as at the moment I don't know how only a part of an element can be translated.

Additional context I would like to hear your thoughts on this topic and discuss how it can be solved. And I would like to work on this issue!

araujoarthur0 commented 2 years ago

Hi @SarahRemus, thanks! I assigned it to you. Because of the Mineirês being able to translate the name, I guess this becomes harder than simply keeping the hardcoded string in the .js file. Could we maybe have the hardcoded string by the language not being the PT-mi?

SarahRemus commented 2 years ago

Is it a hard requirement for you that in Mineirês the "Time to Leave" string is translated? As far as I understood it in #861, it was just not so important that the translation is correct here, "given it is a joke language and consistency doesn't really matter."

I'm asking because it makes solving this issue a lot more complicated and the solution less "clean".

Also, the main title and the main window label are not translated in Mineirês.

tupaschoal commented 1 year ago

@SarahRemus sorry for keeping you waiting!

The title translation on Mineirês is a nice joke, but if it makes things more complicated, just drop it, I'm a lot more comfortable making sure things are simple and consistent than adding a hack or workaround just to make sure a joke works :P

SarahRemus commented 1 year ago

That's what I was thinking ;)

I'm currently working on #913, but will get back to this issue as soon as I can.