search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 271 forks source link

Preferences Reset Feature #917

Closed sisir-umich closed 10 months ago

sisir-umich commented 1 year ago

Related issue

Closes #891

Context / Background

It was recently requested that a feature to reset preferences to their default values would be useful, so this implements that functionality.

What change is being introduced by this PR?

This PR is to review a "Reset" button in the preferences window that returns the preferences to their default values. To indicate that the reset occurred, the button's text changes to "Resetted!" (Attached are screenshots of this functionality). Upon closing the Preferences window, the preferences return to default in the main TTL window. To accomplish this, I added a new button to the src/preferences.html file with styling in the css/styles.css file. The corresponding functionality is implemented in the resetPreferences() method in src/preferences.js. Since it was difficult to update the preferences within the window as soon as the button is pressed and to create a pop-up, the text change on the button can indicate to the user that their action was successful. However, this is a rudimentary solution, and changes can be made by modifying the resetPreferences() method.

Screen Shot 2022-12-02 at 7 52 19 PM Screen Shot 2022-12-02 at 7 52 30 PM

How will this be tested?

There has been a unit test added that performs a click on the new button using Jquery, and the corresponding text change verifies that the button responds to the click. Underlying preferences changes can be verified by running the applications, changing some preferences, pressing "Reset", and seeing if the changes occur.

sisir-umich commented 1 year ago

Hi @araujoarthur0 if you get a chance, could you provide some feedback about these changes? We'd appreciate any suggested edits or idea - thanks!

tupaschoal commented 1 year ago

Hi @sisir-umich!

Can you look into the issues Arthur and I brought up and update the PR, please?

Thanks!

sisir-umich commented 1 year ago

Hi @sisir-umich!

Can you look into the issues Arthur and I brought up and update the PR, please?

Thanks!

Definitely - thanks for the suggestions! We do have our final exams this week and next week, so we plan to be working on these revisions after a few weeks. We'll let you know if we get stuck anywhere.

tupaschoal commented 1 year ago

@sisir-umich are you intending to finish this PR? Thanks!

sisir-umich commented 1 year ago

@tupaschoal I haven't gotten a chance to finish this PR, thanks.

thamara commented 11 months ago

@sisir-umich Do you think you'll be able to return to this?

tupaschoal commented 10 months ago

I resumed this on #1055, sorry for closing instead of taking it in your repo's main.