Refactor calendar and raise coverage

ochan12 commented 1 year ago

Related issue

Not a specific issue but an attempt to raise the coverage

Context / Background

During a previous PR I was getting that the coverage was not enough so I started writing tests, but ended up being bigger than expected. So now I started to group tests and changes that are only related between themselves.

What change is being introduced by this PR?

CalendarFactory was simplified in order to use the same steps when building calendars
Small issue on BaseCalendar that was checking the wrong variable. Also internalStore was defined as an array and then used as an object. Now is both and object.
Raise the coverage by adding tests on CalendarFactory and BaseCalendar. Since this was already big, I decided to close it here and then continue with FlexibleDayCalendar and FlexiblemonthCalendar on another steps.

How will this be tested?

I tried to be as extensive as I could. Not all of them are 100% coverage but it is better than before

[ ] I confirm I'm a native or fluent speaker of the language I'm translating to.

araujoarthur0 commented 1 year ago

Great set of tests :)

ochan12 commented 1 year ago

@araujoarthur0 I've resolved everything so feel free to go through it again!

thamara commented 1 year ago

\changelog-update Message: Fix [#929]: Improved code coverage and fixed some bugs along the way. User: ochan12

thamara commented 1 year ago

Thanks @ochan12!

thamara / time-to-leave