thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

Cannot scroll down the window in calendar view / mode #948

Open timagixe opened 1 year ago

timagixe commented 1 year ago

Describe the issue When app is opened on month view, user cannot scroll the app when mouse is over the HH:MM input row.

To Reproduce Steps to reproduce the behavior:

  1. Go to Calendar view
  2. Change the window size to make scroll bar appear
  3. Hover mouse over hours and minutes input and try to scroll down
  4. The window won't scroll

Expected behavior The window is scrollable

Environment

Screenshots

https://user-images.githubusercontent.com/60817786/219939104-c130667e-114a-4e6b-ac41-845999920b46.mov

araujoarthur0 commented 1 year ago

This is intended behavior. Placing the mouse on lines turns the scroll wheel into horizontal scrolling. So one can see better when there are many entries.

araujoarthur0 commented 1 year ago

I wonder if we could make it more dynamic though. Making it so the scrolling only changes when there is active content to scroll.

tupaschoal commented 1 year ago

Or even do something like: switch to horizontal scrolling, but if it reaches the edges of horizontal scrolling (leftmost or rightmost scroll position) then start scrolling vertically.

ellieliiii commented 1 year ago

Hey! I think I've fixed the issue. Doing a pr right now

ellieliiii commented 1 year ago

Could you assign me to this? I tried to do a pr but didn't have permission

tupaschoal commented 1 year ago

You need to fork the repo and then do a PR. Only maintainers have rights to create branches and push directly on the repo.

ellieliiii commented 1 year ago

my bad, i've forked and made a pull request!