thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

Issues with npm packages #973

Closed araujoarthur0 closed 1 year ago

araujoarthur0 commented 1 year ago

We've always recommended devs to use npm ci, which needs a committed package-lock.json file specifying versions. However, that always causes troubles when someone tries to add a new package, as they have to commit a completely new lock file and we can't humanly review the changes. If the file is not committed, the lock file stays broken and future users face problems.

I'm proposing we change back for devs to use npm install. To keep the consistent versions of dependencies, we can change the package.json to have specific versions instead of the ^ notation that allows this command to install any version above the asked one. New packages should be added only with specific versions so we don't have too many changes.