search

thamara / time-to-leave

Log work hours and get notified when it's time to leave the office and start to live.
http://timetoleave.app
GNU General Public License v3.0
463 stars 272 forks source link

Add 'delete all' button #977

Closed JaeYeongJeong closed 1 year ago

JaeYeongJeong commented 1 year ago

Context / Background

It's annoying to delete them one by one

What change is being introduced by this PR?

Added a button with all delete function.

image

araujoarthur0 commented 1 year ago

@JaeYeongJeong thanks for the contribution. Please open issues before creating PRs so we can discuss and plan features.

araujoarthur0 commented 1 year ago

For example, for the goal of deleting more than one waiver at once, I'd suggest a model with checkboxes instead. It is very unlikely that a user who has added many waivers will want to clear them all, but if one wants to delete more than one entry, they can then choose the checkboxes and click a single time to delete. And that also opens up for a "select all" button.

JaeYeongJeong commented 1 year ago

@JaeYeongJeong thanks for the contribution. Please open issues before creating PRs so we can discuss and plan features.

All right. Thank you for answer.

JaeYeongJeong commented 1 year ago

For example, for the goal of deleting more than one waiver at once, I'd suggest a model with checkboxes instead. It is very unlikely that a user who has added many waivers will want to clear them all, but if one wants to delete more than one entry, they can then choose the checkboxes and click a single time to delete. And that also opens up for a "select all" button.

I also think it would be nice to use checkboxes. That's more clear. Thank you for your comments. I try it!