thamara / vscode-code-annotation

Code Annotation Extension for VSCode
https://marketplace.visualstudio.com/items?itemName=tkcandrade.code-annotation
GNU General Public License v3.0
67 stars 27 forks source link

Requesting a code review #34

Closed tyrant5678 closed 3 years ago

tyrant5678 commented 3 years ago

This pull request contains code for the following:

ghost commented 3 years ago

DeepCode's analysis on #feddc6 found:

Description Example fixes
Comparison to NaN is useless. Nothing is equal to NaN, not even NaN. Use Number.isNaN(). Occurrences: :wrench: Example fixes
Two subsequent branches of an if statement have duplicate bodies (here and here). This may be caused by a copy-paste error. If this usage is intentional, consider merging the branches to avoid code duplication. Occurrences: :wrench: Example fixes
Variable range is declared multiple times. Occurrences: :wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

thamara commented 3 years ago

I don't know what happened here, but hope you had fun hahaha

tyrant5678 commented 3 years ago

Yeah, this pull request was a mistake on my part, but thanks for responding anyways haha.