thamara / vscode-code-annotation

Code Annotation Extension for VSCode
https://marketplace.visualstudio.com/items?itemName=tkcandrade.code-annotation
GNU General Public License v3.0
67 stars 27 forks source link

Add keybinding for adding a note #9

Closed thamara closed 4 years ago

thamara commented 4 years ago

All actions for the Extension are triggered via buttons or Command Pallete. It would be nice to have keybinding for the most common actions such as:

We should also have a way of allowing users to customize it. Any work on this direction is welcome.

PrBart commented 4 years ago

I'd like to do this one. Please, assign it to me.

thamara commented 4 years ago

Sure!

PrBart commented 4 years ago

@thamara i almost done the feature. But i have no idea what exact shortcuts i have to set as default. Maybe you have some thoughts on this matter?

thamara commented 4 years ago

That's a hard one... I think somethink like: Ctrl/Cmd + Shift + A -> Add note Ctrl/Cmd + Shift + Opt + A --> Add plain note

PrBart commented 4 years ago

image

This keybinding already taken.

And also i don't think that shortcut with more than 3 buttons is a good idea.

I think about something like: ctrl+alt+n -> Add note ctrl+alt+p -> Add plain note

thamara commented 4 years ago

I think that's a good approach. 👍 Ideally, the users will be capable of changing this. Not sure if this comes for free with you change so far, if not, don't worry, it can be done later.

PrBart commented 4 years ago

As i know all shortcuts locate at keybindings.json so you can see that user can manually edit json file or do it by Keyboard Shortcuts Settings.

So i think you may not to worry about something else besides default shortcuts.

Screenshot_20201005_025857

Screenshot_20201005_025251

thamara commented 4 years ago

That's really good to know. Thank you a lot!