thanatos-tshock / Tiled

Provides alternate tile implementations which improve performance and memory usage
GNU General Public License v3.0
14 stars 6 forks source link

Drawbacks? #2

Closed fernandofig closed 4 years ago

fernandofig commented 4 years ago

This probably should be on a "discussion" section, but there isn't one for this repo, so I'm posting my question here.

I'm intrigued by this plugin - it seems to be specially useful on resource-starved servers, which is my case. But then I'm wondering a few things, which stems from the fact that the README on the repo's root provides little information other than what it does and its benefits:

thanatos-tshock commented 4 years ago

This probably should be on a "discussion" section, but there isn't one for this repo

Nice idea, when it's available for me to setup i will, however i don't usually come back here so hopefully the community will be able to cover it.

Should it be considered safe?

Well yes, it's open source and you can compile it yourself if you're worried about what code is running. Apart from that there is no downside to using it, there is no loss in functionality and it sticks to only reimplementing how tile data is accessed and stored through OTAPI. If it was not working right you probably wouldn't be able to see a world or even load the server correctly.

If it's safe, why hasn't it been submitted to TShock devs to be merged into the core proper?

That's something i'd be interested in but i don't believe they are even using their HeapTile implementation by default. This project was just a result of messing around to see how ITile was able to do improve performance in some cases, and while it works there is a few other ways that could improve things further. I'm not sure if i have the time or if the TShock guys are wanting to do that on their own as they do have some pretty smart guys who could manage this, but i'm open to the idea if they want to pick one of the implementations here or add extra options.